Raspberries/image-specs
2
0
Fork 0
mirror of https://salsa.debian.org/raspi-team/image-specs synced 2026-05-30 06:38:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix shellcheck issue SC2154

Browse Source 
SC2154: var is referenced but not assigned.

The 'rootmnt' variable is set in /usr/share/initramfs-tools/init and if
it's not available, that would be bad.
According to SC2154 you can fix that issue by using '${var:?}' so it
would fail if unset or empty.
So apply that and reference that SC item in the comments.

Also remove it from the exclude list in the CI config file.
This commit is contained in:
Diederik de Haas
2022-11-12 03:24:37 +01:00
parent cf2eb655d9
commit 9bb0488096
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
debian/salsa-ci.yml vendored
View File

@@ -26,7 +26,7 @@ shellcheck:
script:
- apt-get update && apt-get upgrade -y
- apt-get install -y shellcheck
- shellcheck -e SC1090,SC1091,SC2086,SC2154 -s dash $(find rootfs/etc/initramfs-tools -type f -executable | xargs grep -l '^#!/bin/sh')
- shellcheck -e SC1090,SC1091,SC2086 -s dash $(find rootfs/etc/initramfs-tools -type f -executable | xargs grep -l '^#!/bin/sh')
build yamls:
stage: build