Raspberries/mraa
Private
Public Access
2
0
Fork 0
Code Activity

javascript: update C++ standard to C++17 for compatibility with newer Node.js versions

Browse Source 
When compiling mraa on Debian 13, the following error occurs:

```
/usr/include/node/node.h:696:8: error: ‘optional’ in namespace ‘std’ does not name a template type
  696 |   std::optional<std::string> builder_script_path;
      |        ^~~~~~~~
/usr/include/node/node.h:696:3: note: ‘std::optional’ is only available from C++17 onwards
  696 |   std::optional<std::string> builder_script_path;
      |   ^~~
```

Root cause: Node.js version on Debian 13 is 20+, which requires C++17 feature support.

Signed-off-by: Chun Jiao Zhao <chunjiao.zhao@siemens.com>
This commit is contained in:
Chun Jiao Zhao
2025-09-02 17:12:58 +08:00
committed by Tom Ingleby
parent 28fa501b6c
commit 31a352a32d
2 changed files with 29 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
CMakeLists.txt
View File

@@ -90,6 +90,17 @@ if (BUILDCPP)
message(FATAL_ERROR "Target '${targetname}' requires c++11 which is not supported by this compiler")
endif()
endfunction()
# This function adds the c++17 flag to a c++ target (if supported)
function(use_cxx_17 targetname)
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-std=c++17" COMPILER_SUPPORTS_CXX17)
if (COMPILER_SUPPORTS_CXX17)
set_target_properties(${targetname} PROPERTIES COMPILE_FLAGS "-std=c++17")
else()
message(FATAL_ERROR "Target '${targetname}' requires c++17 which is not supported by this compiler")
endif()
endfunction()
endif()
# Set CMAKE_INSTALL_LIBDIR if not defined

24
src/javascript/CMakeLists.txt
View File

@@ -44,8 +44,9 @@ if (BUILDCPP)
# Node 0.12.x V8 engine major version is '3'.
# Node 2.1.0 V8 engine major version is '4'.
# Node 16.0.0 V8 engine major version is '9'.
# Node 18.0.0+ requires C++17 for std::string_view, std::optional, etc.
if (${V8_VERSION_MAJOR} GREATER 8)
set_property (TARGET mraajs PROPERTY CXX_STANDARD 14)
set_property (TARGET mraajs PROPERTY CXX_STANDARD 17)
else ()
set_property (TARGET mraajs PROPERTY CXX_STANDARD 11)
endif ()
@@ -53,14 +54,25 @@ if (BUILDCPP)
if (CMAKE_VERSION VERSION_LESS "3.1")
message (WARNING "Need to use CMAKE version 3.1+, but it is ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}.${CMAKE_PATCH_VERSION}, using a workaround.")
if (CMAKE_COMPILER_IS_GNUCXX)
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.7")
message (FATAL_ERROR "GNU gcc compiler is also too old (need 4.7+, but ${CMAKE_CXX_COMPILER_VERSION}) and does not support C++11 standard.")
if (${V8_VERSION_MAJOR} GREATER 8)
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "7.0")
message (FATAL_ERROR "GNU gcc compiler is too old (need 7.0+, but ${CMAKE_CXX_COMPILER_VERSION}) and does not support C++17 standard.")
endif ()
set (MRAA_CXX11_WORKAROUND_OPTION "-std=gnu++11")
set (MRAA_CXX_WORKAROUND_OPTION "-std=gnu++17")
else ()
set (MRAA_CXX11_WORKAROUND_OPTION "-std=c++11")
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.7")
message (FATAL_ERROR "GNU gcc compiler is too old (need 4.7+, but ${CMAKE_CXX_COMPILER_VERSION}) and does not support C++11 standard.")
endif ()
set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${MRAA_CXX11_WORKAROUND_OPTION} ")
set (MRAA_CXX_WORKAROUND_OPTION "-std=gnu++11")
endif ()
else ()
if (${V8_VERSION_MAJOR} GREATER 8)
set (MRAA_CXX_WORKAROUND_OPTION "-std=c++17")
else ()
set (MRAA_CXX_WORKAROUND_OPTION "-std=c++11")
endif ()
endif ()
set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${MRAA_CXX_WORKAROUND_OPTION} ")
endif ()
endif ()
endif ()