Raspberries/mraa
Private
Public Access
2
0
Fork 0
Code Activity

syslog: remove all fprintf calls and use syslog instead

Browse Source 
Syslog is now used for all error messages, return values in the code should be
used by programmers to see the status of the library/board and syslog can be
used to see quickly from a debugging perspective what has gone wrong. A few
cosmetics where improved as well as a mraa_set_log_level() call where the
syslog log mask can be set directly from libmraa.

Signed-off-by: Brendan Le Foll <brendan.le.foll@intel.com>
This commit is contained in:
Brendan Le Foll
2014-09-25 14:31:04 +01:00
parent 68de395fea
commit 32d8a6f0ca
12 changed files with 184 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/spi/spi.c
View File

@@ -58,8 +58,8 @@ mraa_spi_init(int bus)
}
mraa_spi_bus_t *spi = mraa_setup_spi(bus);
if(bus < 0) {
fprintf(stderr, "Failed. SPI platform Error\n");
if (bus < 0) {
syslog(LOG_ERR, "Failed. SPI platform Error");
return NULL;
}
mraa_spi_context dev = (mraa_spi_context) malloc(sizeof(struct _spi));
@@ -70,7 +70,7 @@ mraa_spi_init(int bus)
dev->devfd = open(path, O_RDWR);
if (dev->devfd < 0) {
fprintf(stderr, "Failed opening SPI Device. bus:%s\n", path);
syslog(LOG_ERR, "Failed opening SPI Device. bus:%s", path);
free(dev);
return NULL;
}
@@ -113,7 +113,7 @@ mraa_spi_mode(mraa_spi_context dev, mraa_spi_mode_t mode)
}
if (ioctl (dev->devfd, SPI_IOC_WR_MODE, &spi_mode) < 0) {
fprintf(stderr, "Failed to set spi mode\n");
syslog(LOG_ERR, "Failed to set spi mode");
return MRAA_ERROR_INVALID_RESOURCE;
}
@@ -136,7 +136,7 @@ mraa_spi_lsbmode(mraa_spi_context dev, mraa_boolean_t lsb)
lsb_mode = 1;
}
if (ioctl (dev->devfd, SPI_IOC_WR_LSB_FIRST, &lsb_mode) < 0) {
fprintf(stderr, "Failed to set bit order\n");
syslog(LOG_ERR, "Failed to set bit order");
return MRAA_ERROR_INVALID_RESOURCE;
}
dev->lsb = lsb;
@@ -166,7 +166,7 @@ mraa_spi_write(mraa_spi_context dev, uint8_t data)
msg.delay_usecs = 0;
msg.len = length;
if (ioctl(dev->devfd, SPI_IOC_MESSAGE(1), &msg) < 0) {
fprintf(stderr, "Failed to perform dev transfer\n");
syslog(LOG_ERR, "Failed to perform dev transfer");
return -1;
}
return recv;
@@ -187,7 +187,7 @@ mraa_spi_write_buf(mraa_spi_context dev, uint8_t* data, int length)
msg.delay_usecs = 0;
msg.len = length;
if (ioctl(dev->devfd, SPI_IOC_MESSAGE(1), &msg) < 0) {
fprintf(stderr, "Failed to perform dev transfer\n");
syslog(LOG_ERR, "Failed to perform dev transfer");
return NULL;
}
return recv;