Raspberries/mraa
Private
Public Access
2
0
Fork 0
Code Activity

gpio.c,aio.c,iio.c: misc fixes of static code analysis findings

Browse Source 
SonarQube is awesome!

Signed-off-by: Alex Tereschenko <alext.mkrs@gmail.com>
This commit is contained in:
Alex Tereschenko
2017-05-17 20:28:41 +02:00
parent b73fdff00d
commit 816be65ba0
3 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/aio/aio.c
View File

@@ -37,6 +37,11 @@ static int raw_bits;
static mraa_result_t static mraa_result_t
aio_get_valid_fp(mraa_aio_context dev) aio_get_valid_fp(mraa_aio_context dev)
{ {
if (dev == NULL) {
syslog(LOG_ERR, "aio: get_valid_fp: context is invalid");
return MRAA_ERROR_INVALID_HANDLE;
}
if (IS_FUNC_DEFINED(dev, aio_get_valid_fp)) { if (IS_FUNC_DEFINED(dev, aio_get_valid_fp)) {
return dev->advance_func->aio_get_valid_fp(dev); return dev->advance_func->aio_get_valid_fp(dev);
} }

5
src/gpio/gpio.c
View File

@@ -238,6 +238,11 @@ mraa_gpio_wait_interrupt(int fd
static void* static void*
mraa_gpio_interrupt_handler(void* arg) mraa_gpio_interrupt_handler(void* arg)
{ {
if (arg == NULL) {
syslog(LOG_ERR, "gpio: interrupt_handler: context is invalid");
return NULL;
}
mraa_gpio_context dev = (mraa_gpio_context) arg; mraa_gpio_context dev = (mraa_gpio_context) arg;
int fp = -1; int fp = -1;
mraa_result_t ret; mraa_result_t ret;

2
src/iio/iio.c
View File

@@ -465,7 +465,7 @@ mraa_iio_event_poll(mraa_iio_context dev, struct iio_event_data* data)
if (ret == -1 || event_fd == -1) if (ret == -1 || event_fd == -1)
return MRAA_ERROR_UNSPECIFIED; return MRAA_ERROR_UNSPECIFIED;
ret = read(event_fd, data, sizeof(struct iio_event_data)); read(event_fd, data, sizeof(struct iio_event_data));
close(event_fd); close(event_fd);
return MRAA_SUCCESS; return MRAA_SUCCESS;