Private
Public Access
2
0

ftdi_ft4222.c: clean up, styling fix

Signed-off-by: Brendan Le Foll <brendan.le.foll@intel.com>
This commit is contained in:
Brendan Le Foll
2015-08-25 15:51:02 +01:00
parent a49d8d6d12
commit fc55088c03

View File

@@ -33,11 +33,11 @@
#include "usb/ftdi_ft4222.h" #include "usb/ftdi_ft4222.h"
#define PLATFORM_NAME "FTDI FT4222" #define PLATFORM_NAME "FTDI FT4222"
#define I2CM_ERROR(status) (((status) & 0x02) != 0) #define I2CM_ERROR(status) (((status) &0x02) != 0)
#define PCA9672_ADDR 0x20 #define PCA9672_ADDR 0x20
static FT_HANDLE ftHandle = (FT_HANDLE)NULL; static FT_HANDLE ftHandle = (FT_HANDLE) NULL;
static int bus_speed = 400; static int bus_speed = 400;
static int numI2cGpioExapnderPins = 8; static int numI2cGpioExapnderPins = 8;
static int numUsbGpio = 0; static int numUsbGpio = 0;
@@ -48,56 +48,53 @@ mraa_ftdi_ft4222_init()
{ {
mraa_result_t mraaStatus = MRAA_SUCCESS; mraa_result_t mraaStatus = MRAA_SUCCESS;
FT_STATUS ftStatus; FT_STATUS ftStatus;
FT_DEVICE_LIST_INFO_NODE *devInfo = NULL; FT_DEVICE_LIST_INFO_NODE* devInfo = NULL;
DWORD numDevs = 0; DWORD numDevs = 0;
int i; int i;
int retCode = 0; int retCode = 0;
ftStatus = FT_CreateDeviceInfoList(&numDevs); ftStatus = FT_CreateDeviceInfoList(&numDevs);
if (ftStatus != FT_OK) if (ftStatus != FT_OK) {
{
syslog(LOG_ERR, "FT_CreateDeviceInfoList failed: error code %d\n", ftStatus); syslog(LOG_ERR, "FT_CreateDeviceInfoList failed: error code %d\n", ftStatus);
mraaStatus = MRAA_ERROR_NO_RESOURCES; mraaStatus = MRAA_ERROR_NO_RESOURCES;
goto init_exit; goto init_exit;
} }
if (numDevs == 0) if (numDevs == 0) {
{
syslog(LOG_ERR, "No FT4222 devices connected.\n"); syslog(LOG_ERR, "No FT4222 devices connected.\n");
goto init_exit; goto init_exit;
} }
devInfo = calloc((size_t)numDevs, sizeof(FT_DEVICE_LIST_INFO_NODE)); devInfo = calloc((size_t) numDevs, sizeof(FT_DEVICE_LIST_INFO_NODE));
if (devInfo == NULL) if (devInfo == NULL) {
{
syslog(LOG_ERR, "FT4222 allocation failure.\n"); syslog(LOG_ERR, "FT4222 allocation failure.\n");
mraaStatus = MRAA_ERROR_NO_RESOURCES; mraaStatus = MRAA_ERROR_NO_RESOURCES;
goto init_exit; goto init_exit;
} }
ftStatus = FT_GetDeviceInfoList(devInfo, &numDevs); ftStatus = FT_GetDeviceInfoList(devInfo, &numDevs);
if (ftStatus != FT_OK) if (ftStatus != FT_OK) {
{ syslog(LOG_ERR, "FT_GetDeviceInfoList failed (error code %d)\n", (int) ftStatus);
syslog(LOG_ERR, "FT_GetDeviceInfoList failed (error code %d)\n", (int)ftStatus);
mraaStatus = MRAA_ERROR_NO_RESOURCES; mraaStatus = MRAA_ERROR_NO_RESOURCES;
goto init_exit; goto init_exit;
} }
/* /*
FT4222_Version ft4222Version; FT4222_Version ft4222Version;
FT4222_STATUS ft4222Status = FT4222_GetVersion(ftHandle, &ft4222Version); FT4222_STATUS ft4222Status = FT4222_GetVersion(ftHandle, &ft4222Version);
if (FT4222_OK == ft4222Status){ if (FT4222_OK == ft4222Status){
syslog(LOG_NOTICE, "FT4222_GetVersion %08X %08X\n", ft4222Version.chipVersion, ft4222Version.dllVersion); syslog(LOG_NOTICE, "FT4222_GetVersion %08X %08X\n", ft4222Version.chipVersion,
} else ft4222Version.dllVersion);
syslog(LOG_ERR, "FT4222_GetVersion failed with code %d", ft4222Status); } else
*/ syslog(LOG_ERR, "FT4222_GetVersion failed with code %d", ft4222Status);
*/
syslog(LOG_NOTICE, "FT_GetDeviceInfoList returned %d devices\n", numDevs); syslog(LOG_NOTICE, "FT_GetDeviceInfoList returned %d devices\n", numDevs);
DWORD locationId = 0; DWORD locationId = 0;
for (i = 0; i < numDevs && locationId == 0; ++i) { for (i = 0; i < numDevs && locationId == 0; ++i) {
// printf("%d: type = %d, location = %d\n", i, devInfo[i].Type, devInfo[i].LocId); // printf("%d: type = %d, location = %d\n", i, devInfo[i].Type, devInfo[i].LocId);
if (devInfo[i].Type == FT_DEVICE_4222H_0 || devInfo[i].Type == FT_DEVICE_4222H_3) if (devInfo[i].Type == FT_DEVICE_4222H_0 || devInfo[i].Type == FT_DEVICE_4222H_3)
locationId = devInfo[i].LocId; locationId = devInfo[i].LocId;
} }
if (locationId == 0) { if (locationId == 0) {
syslog(LOG_ERR, "FT_GetDeviceInfoList contains no valid devices\n"); syslog(LOG_ERR, "FT_GetDeviceInfoList contains no valid devices\n");
@@ -105,18 +102,16 @@ mraa_ftdi_ft4222_init()
goto init_exit; goto init_exit;
} }
ftStatus = FT_OpenEx((PVOID)(uintptr_t)locationId, FT_OPEN_BY_LOCATION, &ftHandle); ftStatus = FT_OpenEx((PVOID)(uintptr_t) locationId, FT_OPEN_BY_LOCATION, &ftHandle);
if (ftStatus != FT_OK) if (ftStatus != FT_OK) {
{ syslog(LOG_ERR, "FT_OpenEx failed (error %d)\n", (int) ftStatus);
syslog(LOG_ERR, "FT_OpenEx failed (error %d)\n", (int)ftStatus);
mraaStatus = MRAA_ERROR_NO_RESOURCES; mraaStatus = MRAA_ERROR_NO_RESOURCES;
goto init_exit; goto init_exit;
} }
// Tell the FT4222 to be an I2C Master. // Tell the FT4222 to be an I2C Master.
FT4222_STATUS ft4222Status = FT4222_I2CMaster_Init(ftHandle, bus_speed); FT4222_STATUS ft4222Status = FT4222_I2CMaster_Init(ftHandle, bus_speed);
if (FT4222_OK != ft4222Status) if (FT4222_OK != ft4222Status) {
{
syslog(LOG_ERR, "FT4222_I2CMaster_Init failed (error %d)!\n", ft4222Status); syslog(LOG_ERR, "FT4222_I2CMaster_Init failed (error %d)!\n", ft4222Status);
mraaStatus = MRAA_ERROR_NO_RESOURCES; mraaStatus = MRAA_ERROR_NO_RESOURCES;
goto init_exit; goto init_exit;
@@ -124,8 +119,7 @@ mraa_ftdi_ft4222_init()
// Reset the I2CM registers to a known state. // Reset the I2CM registers to a known state.
ft4222Status = FT4222_I2CMaster_Reset(ftHandle); ft4222Status = FT4222_I2CMaster_Reset(ftHandle);
if (FT4222_OK != ft4222Status) if (FT4222_OK != ft4222Status) {
{
syslog(LOG_ERR, "FT4222_I2CMaster_Reset failed (error %d)!\n", ft4222Status); syslog(LOG_ERR, "FT4222_I2CMaster_Reset failed (error %d)!\n", ft4222Status);
mraaStatus = MRAA_ERROR_NO_RESOURCES; mraaStatus = MRAA_ERROR_NO_RESOURCES;
goto init_exit; goto init_exit;
@@ -133,8 +127,9 @@ mraa_ftdi_ft4222_init()
init_exit: init_exit:
if (devInfo != NULL); if (devInfo != NULL)
free(devInfo); ;
free(devInfo);
if (mraaStatus == MRAA_SUCCESS) if (mraaStatus == MRAA_SUCCESS)
syslog(LOG_NOTICE, "mraa_ftdi_ft4222_init completed successfully\n"); syslog(LOG_NOTICE, "mraa_ftdi_ft4222_init completed successfully\n");
return mraaStatus; return mraaStatus;
@@ -147,13 +142,13 @@ mraa_ftdi_ft4222_get_version(unsigned int* versionChip, unsigned int* versionLib
if (ftHandle != NULL) { if (ftHandle != NULL) {
FT4222_Version ft4222Version; FT4222_Version ft4222Version;
FT4222_STATUS ft4222Status = FT4222_GetVersion(ftHandle, &ft4222Version); FT4222_STATUS ft4222Status = FT4222_GetVersion(ftHandle, &ft4222Version);
if (FT4222_OK == ft4222Status){ if (FT4222_OK == ft4222Status) {
*versionChip = (unsigned int)ft4222Version.chipVersion; *versionChip = (unsigned int) ft4222Version.chipVersion;
*versionLib = (unsigned int)ft4222Version.dllVersion; *versionLib = (unsigned int) ft4222Version.dllVersion;
syslog(LOG_NOTICE, "FT4222_GetVersion %08X %08X\n", *versionChip, *versionLib); syslog(LOG_NOTICE, "FT4222_GetVersion %08X %08X\n", *versionChip, *versionLib);
return MRAA_SUCCESS; return MRAA_SUCCESS;
} else { } else {
syslog(LOG_ERR, "libmraa: FT4222_GetVersion failed (error %d)\n", (int)ft4222Status); syslog(LOG_ERR, "libmraa: FT4222_GetVersion failed (error %d)\n", (int) ft4222Status);
return MRAA_ERROR_NO_RESOURCES; return MRAA_ERROR_NO_RESOURCES;
} }
} else { } else {
@@ -167,13 +162,12 @@ static int
mraa_ftdi_ft4222_i2c_read_internal(FT_HANDLE handle, uint8_t addr, uint8_t* data, int length) mraa_ftdi_ft4222_i2c_read_internal(FT_HANDLE handle, uint8_t addr, uint8_t* data, int length)
{ {
uint16 bytesRead = 0; uint16 bytesRead = 0;
uint8 controllerStatus; uint8 controllerStatus;
// syslog(LOG_NOTICE, "FT4222_I2CMaster_Read(%#02X, %#02X)", addr, length); // syslog(LOG_NOTICE, "FT4222_I2CMaster_Read(%#02X, %#02X)", addr, length);
FT4222_STATUS ft4222Status = FT4222_I2CMaster_Read(handle, addr, data, length, &bytesRead); FT4222_STATUS ft4222Status = FT4222_I2CMaster_Read(handle, addr, data, length, &bytesRead);
ft4222Status = FT4222_I2CMaster_GetStatus(ftHandle, &controllerStatus); ft4222Status = FT4222_I2CMaster_GetStatus(ftHandle, &controllerStatus);
if (FT4222_OK != ft4222Status || I2CM_ERROR(controllerStatus)) if (FT4222_OK != ft4222Status || I2CM_ERROR(controllerStatus)) {
{ syslog(LOG_ERR, "FT4222_I2CMaster_Read failed (error %d)\n", (int) ft4222Status);
syslog(LOG_ERR, "FT4222_I2CMaster_Read failed (error %d)\n", (int)ft4222Status);
return 0; return 0;
} }
return bytesRead; return bytesRead;
@@ -183,20 +177,20 @@ static int
mraa_ftdi_ft4222_i2c_write_internal(FT_HANDLE handle, uint8_t addr, const uint8_t* data, int bytesToWrite) mraa_ftdi_ft4222_i2c_write_internal(FT_HANDLE handle, uint8_t addr, const uint8_t* data, int bytesToWrite)
{ {
uint16 bytesWritten = 0; uint16 bytesWritten = 0;
uint8 controllerStatus; uint8 controllerStatus;
// syslog(LOG_NOTICE, "FT4222_I2CMaster_Write(%#02X, %#02X, %d)", addr, *data, bytesToWrite); // syslog(LOG_NOTICE, "FT4222_I2CMaster_Write(%#02X, %#02X, %d)", addr, *data, bytesToWrite);
FT4222_STATUS ft4222Status = FT4222_I2CMaster_Write(handle, addr, (uint8_t*)data, bytesToWrite, &bytesWritten); FT4222_STATUS ft4222Status =
ft4222Status = FT4222_I2CMaster_GetStatus(ftHandle, &controllerStatus); FT4222_I2CMaster_Write(handle, addr, (uint8_t*) data, bytesToWrite, &bytesWritten);
if (FT4222_OK != ft4222Status || I2CM_ERROR(controllerStatus)) ft4222Status = FT4222_I2CMaster_GetStatus(ftHandle, &controllerStatus);
{ if (FT4222_OK != ft4222Status || I2CM_ERROR(controllerStatus)) {
syslog(LOG_ERR, "FT4222_I2CMaster_Write failed (error %d)\n", (int)ft4222Status); syslog(LOG_ERR, "FT4222_I2CMaster_Write failed (error %d)\n", (int) ft4222Status);
return 0; return 0;
} }
if (bytesWritten != bytesToWrite) if (bytesWritten != bytesToWrite)
syslog(LOG_ERR, "FT4222_I2CMaster_Write wrote %u of %u bytes.\n", bytesWritten, bytesToWrite); syslog(LOG_ERR, "FT4222_I2CMaster_Write wrote %u of %u bytes.\n", bytesWritten, bytesToWrite);
return bytesWritten; return bytesWritten;
} }
@@ -208,24 +202,20 @@ mraa_ftdi_ft4222_detect_io_expander()
} }
/******************* I2C functions *******************/ /******************* I2C functions *******************/
static mraa_i2c_context static mraa_i2c_context
mraa_ftdi_ft4222_i2c_init_raw(unsigned int bus) mraa_ftdi_ft4222_i2c_init_raw(unsigned int bus)
{ {
// Tell the FT4222 to be an I2C Master. // Tell the FT4222 to be an I2C Master.
FT4222_STATUS ft4222Status = FT4222_I2CMaster_Init(ftHandle, bus_speed); FT4222_STATUS ft4222Status = FT4222_I2CMaster_Init(ftHandle, bus_speed);
if (FT4222_OK != ft4222Status) if (FT4222_OK != ft4222Status) {
{
syslog(LOG_ERR, "FT4222_I2CMaster_Init failed (error %d)!\n", ft4222Status); syslog(LOG_ERR, "FT4222_I2CMaster_Init failed (error %d)!\n", ft4222Status);
return NULL; return NULL;
} }
// Reset the I2CM registers to a known state. // Reset the I2CM registers to a known state.
ft4222Status = FT4222_I2CMaster_Reset(ftHandle); ft4222Status = FT4222_I2CMaster_Reset(ftHandle);
if (FT4222_OK != ft4222Status) if (FT4222_OK != ft4222Status) {
{
syslog(LOG_ERR, "FT4222_I2CMaster_Reset failed (error %d)!\n", ft4222Status); syslog(LOG_ERR, "FT4222_I2CMaster_Reset failed (error %d)!\n", ft4222Status);
return NULL; return NULL;
} }
@@ -237,8 +227,9 @@ mraa_ftdi_ft4222_i2c_init_raw(unsigned int bus)
} }
dev->handle = ftHandle; dev->handle = ftHandle;
dev->fh = -1; // We don't use file descriptors dev->fh = -1; // We don't use file descriptors
dev->funcs = I2C_FUNC_I2C; // Advertise minimal i2c support as per https://www.kernel.org/doc/Documentation/i2c/functionality dev->funcs = I2C_FUNC_I2C; // Advertise minimal i2c support as per
// https://www.kernel.org/doc/Documentation/i2c/functionality
return dev; return dev;
} }
@@ -247,23 +238,22 @@ mraa_ftdi_ft4222_i2c_init_bus_replace(mraa_i2c_context dev)
{ {
// Tell the FT4222 to be an I2C Master. // Tell the FT4222 to be an I2C Master.
FT4222_STATUS ft4222Status = FT4222_I2CMaster_Init(ftHandle, 400); FT4222_STATUS ft4222Status = FT4222_I2CMaster_Init(ftHandle, 400);
if (FT4222_OK != ft4222Status) if (FT4222_OK != ft4222Status) {
{
syslog(LOG_ERR, "FT4222_I2CMaster_Init failed (error %d)!\n", ft4222Status); syslog(LOG_ERR, "FT4222_I2CMaster_Init failed (error %d)!\n", ft4222Status);
return MRAA_ERROR_NO_RESOURCES; return MRAA_ERROR_NO_RESOURCES;
} }
// Reset the I2CM registers to a known state. // Reset the I2CM registers to a known state.
ft4222Status = FT4222_I2CMaster_Reset(ftHandle); ft4222Status = FT4222_I2CMaster_Reset(ftHandle);
if (FT4222_OK != ft4222Status) if (FT4222_OK != ft4222Status) {
{
syslog(LOG_ERR, "FT4222_I2CMaster_Reset failed (error %d)!\n", ft4222Status); syslog(LOG_ERR, "FT4222_I2CMaster_Reset failed (error %d)!\n", ft4222Status);
return MRAA_ERROR_NO_RESOURCES; return MRAA_ERROR_NO_RESOURCES;
} }
dev->handle = ftHandle; dev->handle = ftHandle;
dev->fh = -1; // We don't use file descriptors dev->fh = -1; // We don't use file descriptors
dev->funcs = I2C_FUNC_I2C; // Advertise minimal i2c support as per https://www.kernel.org/doc/Documentation/i2c/functionality dev->funcs = I2C_FUNC_I2C; // Advertise minimal i2c support as per
// https://www.kernel.org/doc/Documentation/i2c/functionality
return MRAA_SUCCESS; return MRAA_SUCCESS;
} }
@@ -272,15 +262,15 @@ static mraa_result_t
mraa_ftdi_ft4222_i2c_frequency(mraa_i2c_context dev, mraa_i2c_mode_t mode) mraa_ftdi_ft4222_i2c_frequency(mraa_i2c_context dev, mraa_i2c_mode_t mode)
{ {
switch (mode) { switch (mode) {
case MRAA_I2C_STD: /**< up to 100Khz */ case MRAA_I2C_STD: /**< up to 100Khz */
bus_speed = 100; bus_speed = 100;
break; break;
MRAA_I2C_FAST: /**< up to 400Khz */ MRAA_I2C_FAST: /**< up to 400Khz */
bus_speed = 400; bus_speed = 400;
break; break;
MRAA_I2C_HIGH: /**< up to 3.4Mhz */ MRAA_I2C_HIGH: /**< up to 3.4Mhz */
bus_speed = 3400; bus_speed = 3400;
break; break;
} }
return MRAA_SUCCESS; return MRAA_SUCCESS;
} }
@@ -324,7 +314,7 @@ static mraa_result_t
mraa_ftdi_ft4222_i2c_write(mraa_i2c_context dev, const uint8_t* data, int bytesToWrite) mraa_ftdi_ft4222_i2c_write(mraa_i2c_context dev, const uint8_t* data, int bytesToWrite)
{ {
uint16 bytesWritten = mraa_ftdi_ft4222_i2c_write_internal(dev->handle, dev->addr, data, bytesToWrite); uint16 bytesWritten = mraa_ftdi_ft4222_i2c_write_internal(dev->handle, dev->addr, data, bytesToWrite);
return bytesToWrite == bytesWritten ? MRAA_SUCCESS : MRAA_ERROR_INVALID_HANDLE; return bytesToWrite == bytesWritten ? MRAA_SUCCESS : MRAA_ERROR_INVALID_HANDLE;
} }
@@ -361,7 +351,7 @@ mraa_ftdi_ft4222_i2c_write_word_data(mraa_i2c_context dev, const uint16_t data,
{ {
uint8_t buf[3]; uint8_t buf[3];
buf[0] = command; buf[0] = command;
buf[1] = (uint8_t)data; buf[1] = (uint8_t) data;
buf[2] = (uint8_t)(data >> 8); buf[2] = (uint8_t)(data >> 8);
return mraa_ftdi_ft4222_i2c_write(dev, buf, 3); return mraa_ftdi_ft4222_i2c_write(dev, buf, 3);
} }
@@ -425,12 +415,13 @@ static mraa_result_t
mraa_ftdi_ft4222_gpio_dir_replace(mraa_gpio_context dev, mraa_gpio_dir_t dir) mraa_ftdi_ft4222_gpio_dir_replace(mraa_gpio_context dev, mraa_gpio_dir_t dir)
{ {
switch (dir) { switch (dir) {
case MRAA_GPIO_IN: case MRAA_GPIO_IN:
case MRAA_GPIO_OUT_HIGH: case MRAA_GPIO_OUT_HIGH:
return mraa_ftdi_ft4222_gpio_write_replace(dev, 1); return mraa_ftdi_ft4222_gpio_write_replace(dev, 1);
case MRAA_GPIO_OUT_LOW: case MRAA_GPIO_OUT_LOW:
return mraa_ftdi_ft4222_gpio_write_replace(dev, 0); return mraa_ftdi_ft4222_gpio_write_replace(dev, 0);
default:; default:
;
} }
return MRAA_SUCCESS; return MRAA_SUCCESS;
} }
@@ -438,14 +429,15 @@ mraa_ftdi_ft4222_gpio_dir_replace(mraa_gpio_context dev, mraa_gpio_dir_t dir)
static void static void
mraa_ftdi_ft4222_sleep_ms(unsigned long mseconds) mraa_ftdi_ft4222_sleep_ms(unsigned long mseconds)
{ {
struct timespec sleepTime; struct timespec sleepTime;
sleepTime.tv_sec = mseconds / 1000; // Number of seconds sleepTime.tv_sec = mseconds / 1000; // Number of seconds
sleepTime.tv_nsec = ( mseconds % 1000 ) * 1000000; // Convert fractional seconds to nanoseconds sleepTime.tv_nsec = (mseconds % 1000) * 1000000; // Convert fractional seconds to nanoseconds
// Iterate nanosleep in a loop until the total sleep time is the original // Iterate nanosleep in a loop until the total sleep time is the original
// value of the seconds parameter // value of the seconds parameter
while ( ( nanosleep( &sleepTime, &sleepTime ) != 0 ) && ( errno == EINTR ) ); while ((nanosleep(&sleepTime, &sleepTime) != 0) && (errno == EINTR))
;
} }
static void* static void*
@@ -516,7 +508,7 @@ mraa_ftdi_ft4222()
// Virtual gpio pins on i2c I/O expander. // Virtual gpio pins on i2c I/O expander.
mraa_pincapabilities_t pinCapsGpio = (mraa_pincapabilities_t){ 1, 1, 0, 0, 0, 0, 0, 0 }; mraa_pincapabilities_t pinCapsGpio = (mraa_pincapabilities_t){ 1, 1, 0, 0, 0, 0, 0, 0 };
for (pinIndex=0; pinIndex < numUsbGpio; ++pinIndex) { for (pinIndex = 0; pinIndex < numUsbGpio; ++pinIndex) {
char name[8]; char name[8];
sprintf(name, "Pin%d", pinIndex); sprintf(name, "Pin%d", pinIndex);
strncpy(sub_plat->pins[pinIndex].name, name, 8); strncpy(sub_plat->pins[pinIndex].name, name, 8);
@@ -552,4 +544,3 @@ mraa_ftdi_ft4222()
sub_plat->adv_func = func_table; sub_plat->adv_func = func_table;
return sub_plat; return sub_plat;
} }