Raspberries/mraa
Private
Public Access
2
0
Fork 0
Code Activity

gpio: chardev: fix leaking of gpiochip file descriptors

Browse Source 
The following APIs are only used for getting the line information from
kernel by opening the gpiochip independently and they fails to close
the file descriptor when done:

1. mraa_get_line_info_by_chip_number()
2. mraa_get_line_info_by_chip_name()
3. mraa_get_line_info_by_chip_label()

This will create issue if these API consumers like mraa_gpio_read_dir(),
mraa_gpio_mode(), mraa_gpio_chardev_dir() gets called in a loop. The
system will run out of file descriptor after some time.

Fix this issue by closing the opened file descriptors before freeing
the cinfo struct.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: malikabhi05 <abhishek.malik@intel.com>
This commit is contained in:
Manivannan Sadhasivam
2018-04-17 08:49:26 +05:30
committed by malikabhi05
parent b59fc8f076
commit b04e728957
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/gpio/gpio_chardev.c
View File

@@ -295,6 +295,7 @@ mraa_get_line_info_by_chip_number(unsigned chip_number, unsigned line_number)
linfo = mraa_get_line_info_from_descriptor(cinfo->chip_fd, line_number);
close(cinfo->chip_fd);
free(cinfo);
return linfo;
@@ -314,6 +315,7 @@ mraa_get_line_info_by_chip_name(const char* chip_name, unsigned line_number)
linfo = mraa_get_line_info_from_descriptor(cinfo->chip_fd, line_number);
close(cinfo->chip_fd);
free(cinfo);
return linfo;
@@ -333,6 +335,7 @@ mraa_get_line_info_by_chip_label(const char* chip_label, unsigned line_number)
linfo = mraa_get_line_info_from_descriptor(cinfo->chip_fd, line_number);
close(cinfo->chip_fd);
free(cinfo);
return linfo;